Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing scheduler label for trimSugarFeeds #9054

Merged
merged 1 commit into from Mar 25, 2021
Merged

Add missing scheduler label for trimSugarFeeds #9054

merged 1 commit into from Mar 25, 2021

Conversation

tsmgeek
Copy link
Contributor

@tsmgeek tsmgeek commented Mar 5, 2021

Scheduler label missing.

@pgorod
Copy link
Contributor

pgorod commented Mar 5, 2021

This is related to Group F of this larger issue: #4291

But since the entire group seems to be already there, the simple thing to do is exactly what this PR does, add the single label that is missing.

@pgorod pgorod mentioned this pull request Mar 6, 2021
Open
@jack7anderson7
Copy link
Contributor

Hi tsmgeek,

The label you are trying to add already exists within the file you're trying to add it to just under the name 'LBL_OOTB_SUITEFEEDS'.

@jack7anderson7 jack7anderson7 added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Mar 19, 2021
@tsmgeek
Copy link
Contributor Author

tsmgeek commented Mar 19, 2021 •
edited

@jack7anderson7 OOTB labels are only used when the schedulers are created by default to set the Name field, ie on a new install.
Im talking about when you go to create a scheduler and click the list of functions, in there it will use the other label.

SuiteCRM/modules/Schedulers/EditView.php

Lines 154 to 165 in e523df7

include_once('modules/Schedulers/_AddJobsHere.php');
if (is_array($job_strings) && !empty($job_strings)) {
$job_function = "<option value=''>--</option>";
foreach ($job_strings as $k => $function) {
$job_function .= "<option value='function::".$function."'";
if ($focus->job === "function::".$function) {
$job_function .= " SELECTED ";
}
$job_function .= ">".$mod_strings['LBL_'.strtoupper($function)]."</option>";
}
}

@mattlorimer mattlorimer merged commit 1981e7e into salesagility:hotfix-7.10.x Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlorimer mattlorimer mattlorimer approved these changes

@jack7anderson7 jack7anderson7 jack7anderson7 approved these changes

Assignees
No one assigned
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tsmgeek @pgorod @jack7anderson7 @mattlorimer